-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Deploy-UserCertificate Functions to generate certs on SHA match #612
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me. Was able to test successfully in my org and the updated sha triggers are working.
Nice job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work here. Tests good with my org.
Issues
What does this solve?
This release aims to reduce the amount of time required to generate and deploy certificates for users. In previous iterations of this script, the tool would generate a new command each time the script was run for each user. This version changes the command "trigger" to the SHA1 hash of a user's certificate and compares that value when running Start-DeployUserCerts.
This release also introduces a multi-threaded operation when the tool generates commands for "new" or "all" users in the radiusMembers list.
Is there anything particularly tricky?
How should this be tested?
Functionality for the changes should be already covered in our Pester tests for this module. To validate the changes in this pull request. Pull the branch, open up the
scripts/automation/Radius
directory in a PowerShell session and run the pester tests on one of our Pester Tests orgs:./tests/Invoke-Pester.ps1 -JumpCloudApiKey {YourPesterTestAPIKey}
In terms of updating from a previous version of the 2.0.0 development branch of radius certs:
$forceGenerateCommands
parameter is specified.Before:
After:
Screenshots
Preliminary testing indicates that this version of the script runs about 47% faster than the previous version.
Newest version (running threads in parallel to generate commands)
Previous version (running single threaded and in sequence to generate commands)